ci: tag regex

.github/workflows/build-and-draft-release.yml

@@ -4,7 +4,9 @@ on:
   workflow_dispatch:
   push:
     tags:
-      - "v[0-9]+.[0-9]+.[0-9]+"
+      # regex taken from
+      # https://packaging.python.org/en/latest/specifications/version-specifiers/#appendix-parsing-version-strings-with-regular-expressions
+      - '^([1-9][0-9]*!)?(0|[1-9][0-9]*)(\.(0|[1-9][0-9]*))*((a|b|rc)(0|[1-9][0-9]*))?(\.post(0|[1-9][0-9]*))?(\.dev(0|[1-9][0-9]*))?$'
 
 permissions:
   contents: write
@@ -29,14 +31,6 @@ jobs:
           pip install build
           python -m build
 
-      - name: Remove `v` in tag name
-        uses: mad9000/actions-find-and-replace-string@5
-        id: tagNameReplaced
-        with:
-          source: ${{ github.ref_name }}
-          find: "v"
-          replace: ""
-
       - name: Draft a release
         uses: softprops/action-gh-release@v2
         with:
@@ -44,5 +38,4 @@ jobs:
           draft: true
           generate_release_notes: true
           files: |
-            dist/arcaea_offline_ocr-${{ steps.tagNameReplaced.outputs.value }}*.whl
+            dist/*
-            dist/arcaea-offline-ocr-${{ steps.tagNameReplaced.outputs.value }}.tar.gz

.pre-commit-config.yaml

@@ -4,10 +4,11 @@ repos:
     hooks:
       - id: end-of-file-fixer
       - id: trailing-whitespace
-
+  - repo: https://github.com/psf/black
-  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: 23.1.0
-    rev: v0.11.13
     hooks:
-      - id: ruff
+      - id: black
-        args: ["--fix"]
+  - repo: https://github.com/PyCQA/isort
-      - id: ruff-format
+    rev: 5.12.0
+    hooks:
+      - id: isort

requirements.txt

@@ -1,2 +1,3 @@
-numpy~=2.3
+attrs==23.1.0
-opencv-python~=4.11
+numpy==1.26.1
+opencv-python==4.8.1.78

src/arcaea_offline_ocr/b30/chieri/v4/ocr.py

@@ -1,3 +1,4 @@
+from math import floor
 from typing import List, Optional, Tuple
 
 import cv2
@@ -12,21 +13,9 @@ from ....ocr import (
 )
 from ....phash_db import ImagePhashDatabase
 from ....types import Mat
+from ....utils import construct_int_xywh_rect
 from ...shared import B30OcrResultItem
-from .colors import (
+from .colors import *
-    BYD_MAX_HSV,
-    BYD_MIN_HSV,
-    FAR_BG_MAX_HSV,
-    FAR_BG_MIN_HSV,
-    FTR_MAX_HSV,
-    FTR_MIN_HSV,
-    LOST_BG_MAX_HSV,
-    LOST_BG_MIN_HSV,
-    PRS_MAX_HSV,
-    PRS_MIN_HSV,
-    PURE_BG_MAX_HSV,
-    PURE_BG_MIN_HSV,
-)
 from .rois import ChieriBotV4Rois
 
 
@@ -36,7 +25,7 @@ class ChieriBotV4Ocr:
         score_knn: cv2.ml.KNearest,
         pfl_knn: cv2.ml.KNearest,
         phash_db: ImagePhashDatabase,
-        factor: float = 1.0,
+        factor: Optional[float] = 1.0,
     ):
         self.__score_knn = score_knn
         self.__pfl_knn = pfl_knn
@@ -83,8 +72,9 @@ class ChieriBotV4Ocr:
         self.factor = img.shape[0] / 4400
 
     def ocr_component_rating_class(self, component_bgr: Mat) -> int:
-        rating_class_rect = self.rois.component_rois.rating_class_rect.rounded()
+        rating_class_rect = construct_int_xywh_rect(
-
+            self.rois.component_rois.rating_class_rect
+        )
         rating_class_roi = crop_xywh(component_bgr, rating_class_rect)
         rating_class_roi = cv2.cvtColor(rating_class_roi, cv2.COLOR_BGR2HSV)
         rating_class_masks = [
@@ -99,7 +89,9 @@ class ChieriBotV4Ocr:
             return max(enumerate(rating_class_results), key=lambda i: i[1])[0] + 1
 
     def ocr_component_song_id(self, component_bgr: Mat):
-        jacket_rect = self.rois.component_rois.jacket_rect.floored()
+        jacket_rect = construct_int_xywh_rect(
+            self.rois.component_rois.jacket_rect, floor
+        )
         jacket_roi = cv2.cvtColor(
             crop_xywh(component_bgr, jacket_rect), cv2.COLOR_BGR2GRAY
         )
@@ -107,7 +99,7 @@ class ChieriBotV4Ocr:
 
     def ocr_component_score_knn(self, component_bgr: Mat) -> int:
         # sourcery skip: inline-immediately-returned-variable
-        score_rect = self.rois.component_rois.score_rect.rounded()
+        score_rect = construct_int_xywh_rect(self.rois.component_rois.score_rect)
         score_roi = cv2.cvtColor(
             crop_xywh(component_bgr, score_rect), cv2.COLOR_BGR2GRAY
         )
@@ -127,9 +119,7 @@ class ChieriBotV4Ocr:
             score_roi = cv2.fillPoly(score_roi, [contour], 0)
         return ocr_digits_by_contour_knn(score_roi, self.score_knn)
 
-    def find_pfl_rects(
+    def find_pfl_rects(self, component_pfl_processed: Mat) -> List[List[int]]:
-        self, component_pfl_processed: Mat
-    ) -> List[Tuple[int, int, int, int]]:
         # sourcery skip: inline-immediately-returned-variable
         pfl_roi_find = cv2.morphologyEx(
             component_pfl_processed,
@@ -156,7 +146,7 @@ class ChieriBotV4Ocr:
         return pfl_rects_adjusted
 
     def preprocess_component_pfl(self, component_bgr: Mat) -> Mat:
-        pfl_rect = self.rois.component_rois.pfl_rect.rounded()
+        pfl_rect = construct_int_xywh_rect(self.rois.component_rois.pfl_rect)
         pfl_roi = crop_xywh(component_bgr, pfl_rect)
         pfl_roi_hsv = cv2.cvtColor(pfl_roi, cv2.COLOR_BGR2HSV)
 

src/arcaea_offline_ocr/b30/chieri/v4/rois.py

@@ -1,12 +1,12 @@
-from typing import List
+from typing import List, Optional
 
 from ....crop import crop_xywh
 from ....types import Mat, XYWHRect
-from ....utils import apply_factor
+from ....utils import apply_factor, construct_int_xywh_rect
 
 
 class ChieriBotV4ComponentRois:
-    def __init__(self, factor: float = 1.0):
+    def __init__(self, factor: Optional[float] = 1.0):
         self.__factor = factor
 
     @property
@@ -19,11 +19,11 @@ class ChieriBotV4ComponentRois:
 
     @property
     def top_font_color_detect(self):
-        return apply_factor(XYWHRect(35, 10, 120, 100), self.factor)
+        return apply_factor((35, 10, 120, 100), self.factor)
 
     @property
     def bottom_font_color_detect(self):
-        return apply_factor(XYWHRect(30, 125, 175, 110), self.factor)
+        return apply_factor((30, 125, 175, 110), self.factor)
 
     @property
     def bg_point(self):
@@ -31,31 +31,31 @@ class ChieriBotV4ComponentRois:
 
     @property
     def rating_class_rect(self):
-        return apply_factor(XYWHRect(21, 40, 7, 20), self.factor)
+        return apply_factor((21, 40, 7, 20), self.factor)
 
     @property
     def title_rect(self):
-        return apply_factor(XYWHRect(35, 10, 430, 50), self.factor)
+        return apply_factor((35, 10, 430, 50), self.factor)
 
     @property
     def jacket_rect(self):
-        return apply_factor(XYWHRect(263, 0, 239, 239), self.factor)
+        return apply_factor((263, 0, 239, 239), self.factor)
 
     @property
     def score_rect(self):
-        return apply_factor(XYWHRect(30, 60, 270, 55), self.factor)
+        return apply_factor((30, 60, 270, 55), self.factor)
 
     @property
     def pfl_rect(self):
-        return apply_factor(XYWHRect(50, 125, 80, 100), self.factor)
+        return apply_factor((50, 125, 80, 100), self.factor)
 
     @property
     def date_rect(self):
-        return apply_factor(XYWHRect(205, 200, 225, 25), self.factor)
+        return apply_factor((205, 200, 225, 25), self.factor)
 
 
 class ChieriBotV4Rois:
-    def __init__(self, factor: float = 1.0):
+    def __init__(self, factor: Optional[float] = 1.0):
         self.__factor = factor
         self.__component_rois = ChieriBotV4ComponentRois(factor)
 
@@ -100,7 +100,9 @@ class ChieriBotV4Rois:
     def horizontal_items(self):
         return 3
 
-    vertical_items = 10
+    @property
+    def vertical_items(self):
+        return 10
 
     @property
     def b33_vertical_gap(self):
@@ -110,17 +112,16 @@ class ChieriBotV4Rois:
         first_rect = XYWHRect(x=self.left, y=self.top, w=self.width, h=self.height)
         results = []
 
-        last_rect = first_rect
         for vi in range(self.vertical_items):
             rect = XYWHRect(*first_rect)
             rect += (0, (self.vertical_gap + self.height) * vi, 0, 0)
             for hi in range(self.horizontal_items):
                 if hi > 0:
                     rect += ((self.width + self.horizontal_gap), 0, 0, 0)
-                results.append(crop_xywh(img_bgr, rect.rounded()))
+                int_rect = construct_int_xywh_rect(rect)
-            last_rect = rect
+                results.append(crop_xywh(img_bgr, int_rect))
 
-        last_rect += (
+        rect += (
             -(self.width + self.horizontal_gap) * 2,
             self.height + self.b33_vertical_gap,
             0,
@@ -128,7 +129,8 @@ class ChieriBotV4Rois:
         )
         for hi in range(self.horizontal_items):
             if hi > 0:
-                last_rect += ((self.width + self.horizontal_gap), 0, 0, 0)
+                rect += ((self.width + self.horizontal_gap), 0, 0, 0)
-            results.append(crop_xywh(img_bgr, last_rect.rounded()))
+            int_rect = construct_int_xywh_rect(rect)
+            results.append(crop_xywh(img_bgr, int_rect))
 
         return results

src/arcaea_offline_ocr/b30/shared.py

@@ -1,9 +1,10 @@
-from dataclasses import dataclass
 from datetime import datetime
 from typing import Optional
 
+import attrs
 
-@dataclass
+
+@attrs.define
 class B30OcrResultItem:
     rating_class: int
     score: int

src/arcaea_offline_ocr/core/hashers/__init__.py

@@ -1,3 +0,0 @@
-from .index import average, dct, difference
-
-__all__ = ["average", "dct", "difference"]

src/arcaea_offline_ocr/core/hashers/_common.py

@@ -1,7 +0,0 @@
-import cv2
-
-from arcaea_offline_ocr.types import Mat
-
-
-def _resize_image(src: Mat, dsize: ...) -> Mat:
-    return cv2.resize(src, dsize, fx=0, fy=0, interpolation=cv2.INTER_AREA)

src/arcaea_offline_ocr/core/hashers/index.py

@@ -1,35 +0,0 @@
-import cv2
-import numpy as np
-
-from arcaea_offline_ocr.types import Mat
-
-from ._common import _resize_image
-
-
-def average(img_gray: Mat, hash_size: int) -> Mat:
-    img_resized = _resize_image(img_gray, (hash_size, hash_size))
-    diff = img_resized > img_resized.mean()
-    return diff.flatten()
-
-
-def difference(img_gray: Mat, hash_size: int) -> Mat:
-    img_size = (hash_size + 1, hash_size)
-    img_resized = _resize_image(img_gray, img_size)
-
-    previous = img_resized[:, :-1]
-    current = img_resized[:, 1:]
-    diff = previous > current
-    return diff.flatten()
-
-
-def dct(img_gray: Mat, hash_size: int = 16, high_freq_factor: int = 4) -> Mat:
-    # TODO: consistency?
-    img_size_base = hash_size * high_freq_factor
-    img_size = (img_size_base, img_size_base)
-
-    img_resized = _resize_image(img_gray, img_size)
-    img_resized = img_resized.astype(np.float32)
-    dct_mat = cv2.dct(img_resized)
-
-    hash_mat = dct_mat[:hash_size, :hash_size]
-    return hash_mat > hash_mat.mean()

src/arcaea_offline_ocr/dependencies/ihdb/__init__.py

@@ -1,18 +0,0 @@
-from .builder import ImageHashesDatabaseBuilder
-from .index import ImageHashesDatabase, ImageHashesDatabasePropertyMissingError
-from .models import (
-    ImageHashBuildTask,
-    ImageHashHashType,
-    ImageHashResult,
-    ImageHashCategory,
-)
-
-__all__ = [
-    "ImageHashesDatabase",
-    "ImageHashesDatabasePropertyMissingError",
-    "ImageHashHashType",
-    "ImageHashResult",
-    "ImageHashCategory",
-    "ImageHashesDatabaseBuilder",
-    "ImageHashBuildTask",
-]

src/arcaea_offline_ocr/dependencies/ihdb/builder.py

@@ -1,85 +0,0 @@
-import logging
-from datetime import datetime, timezone
-from sqlite3 import Connection
-from typing import List
-
-from arcaea_offline_ocr.core import hashers
-
-from .index import ImageHashesDatabase
-from .models import ImageHash, ImageHashBuildTask, ImageHashHashType
-
-logger = logging.getLogger(__name__)
-
-
-class ImageHashesDatabaseBuilder:
-    @staticmethod
-    def __insert_property(conn: Connection, key: str, value: str):
-        return conn.execute(
-            "INSERT INTO properties (key, value) VALUES (?, ?)",
-            (key, value),
-        )
-
-    @classmethod
-    def build(
-        cls,
-        conn: Connection,
-        tasks: List[ImageHashBuildTask],
-        *,
-        hash_size: int = 16,
-        high_freq_factor: int = 4,
-    ):
-        rows: List[ImageHash] = []
-
-        for task in tasks:
-            try:
-                img_gray = task.imread_function(task.image_path)
-
-                for hash_type, hash_mat in [
-                    (
-                        ImageHashHashType.AVERAGE,
-                        hashers.average(img_gray, hash_size),
-                    ),
-                    (
-                        ImageHashHashType.DCT,
-                        hashers.dct(img_gray, hash_size, high_freq_factor),
-                    ),
-                    (
-                        ImageHashHashType.DIFFERENCE,
-                        hashers.difference(img_gray, hash_size),
-                    ),
-                ]:
-                    rows.append(
-                        ImageHash(
-                            hash_type=hash_type,
-                            category=task.category,
-                            label=task.label,
-                            hash=ImageHashesDatabase.hash_mat_to_bytes(hash_mat),
-                        )
-                    )
-            except Exception:
-                logger.exception("Error processing task %r", task)
-
-        conn.execute("CREATE TABLE properties (`key` VARCHAR, `value` VARCHAR)")
-        conn.execute(
-            "CREATE TABLE hashes (`hash_type` INTEGER, `category` INTEGER, `label` VARCHAR, `hash` BLOB)"
-        )
-
-        now = datetime.now(tz=timezone.utc)
-        timestamp = int(now.timestamp() * 1000)
-
-        cls.__insert_property(conn, ImageHashesDatabase.KEY_HASH_SIZE, str(hash_size))
-        cls.__insert_property(
-            conn, ImageHashesDatabase.KEY_HIGH_FREQ_FACTOR, str(high_freq_factor)
-        )
-        cls.__insert_property(
-            conn, ImageHashesDatabase.KEY_BUILT_TIMESTAMP, str(timestamp)
-        )
-
-        conn.executemany(
-            "INSERT INTO hashes (hash_type, category, label, hash) VALUES (?, ?, ?, ?)",
-            [
-                (row.hash_type.value, row.category.value, row.label, row.hash)
-                for row in rows
-            ],
-        )
-        conn.commit()

src/arcaea_offline_ocr/dependencies/ihdb/index.py

@@ -1,144 +0,0 @@
-import sqlite3
-from datetime import datetime, timezone
-from typing import Any, Callable, List, Optional, TypeVar
-
-from arcaea_offline_ocr.core import hashers
-from arcaea_offline_ocr.types import Mat
-
-from .models import ImageHashHashType, ImageHashResult, ImageHashCategory
-
-T = TypeVar("T")
-
-
-def _sql_hamming_distance(hash1: bytes, hash2: bytes):
-    assert len(hash1) == len(hash2), "hash size does not match!"
-    count = sum(1 for byte1, byte2 in zip(hash1, hash2) if byte1 != byte2)
-    return count
-
-
-class ImageHashesDatabasePropertyMissingError(Exception):
-    pass
-
-
-class ImageHashesDatabase:
-    KEY_HASH_SIZE = "hash_size"
-    KEY_HIGH_FREQ_FACTOR = "high_freq_factor"
-    KEY_BUILT_TIMESTAMP = "built_timestamp"
-
-    def __init__(self, conn: sqlite3.Connection):
-        self.conn = conn
-        self.conn.create_function("HAMMING_DISTANCE", 2, _sql_hamming_distance)
-
-        self._hash_size: int = -1
-        self._high_freq_factor: int = -1
-        self._built_time: Optional[datetime] = None
-
-        self._hashes_count = {
-            ImageHashCategory.JACKET: 0,
-            ImageHashCategory.PARTNER_ICON: 0,
-        }
-
-        self._hash_length: int = -1
-
-        self._initialize()
-
-    @property
-    def hash_size(self):
-        return self._hash_size
-
-    @property
-    def high_freq_factor(self):
-        return self._high_freq_factor
-
-    @property
-    def hash_length(self):
-        return self._hash_length
-
-    def _initialize(self):
-        def query_property(key, convert_func: Callable[[Any], T]) -> Optional[T]:
-            result = self.conn.execute(
-                "SELECT value FROM properties WHERE key = ?",
-                (key,),
-            ).fetchone()
-            return convert_func(result[0]) if result is not None else None
-
-        def set_hashes_count(category: ImageHashCategory):
-            self._hashes_count[category] = self.conn.execute(
-                "SELECT COUNT(DISTINCT label) FROM hashes WHERE category = ?",
-                (category.value,),
-            ).fetchone()[0]
-
-        hash_size = query_property(self.KEY_HASH_SIZE, lambda x: int(x))
-        if hash_size is None:
-            raise ImageHashesDatabasePropertyMissingError("hash_size")
-        self._hash_size = hash_size
-
-        high_freq_factor = query_property(self.KEY_HIGH_FREQ_FACTOR, lambda x: int(x))
-        if high_freq_factor is None:
-            raise ImageHashesDatabasePropertyMissingError("high_freq_factor")
-        self._high_freq_factor = high_freq_factor
-
-        self._built_time = query_property(
-            self.KEY_BUILT_TIMESTAMP,
-            lambda ts: datetime.fromtimestamp(int(ts) / 1000, tz=timezone.utc),
-        )
-
-        set_hashes_count(ImageHashCategory.JACKET)
-        set_hashes_count(ImageHashCategory.PARTNER_ICON)
-
-        self._hash_length = self._hash_size**2
-
-    def lookup_hash(
-        self, category: ImageHashCategory, hash_type: ImageHashHashType, hash: bytes
-    ) -> List[ImageHashResult]:
-        cursor = self.conn.execute(
-            "SELECT"
-            " label,"
-            " HAMMING_DISTANCE(hash, ?) AS distance"
-            " FROM hashes"
-            " WHERE category = ? AND hash_type = ?"
-            " ORDER BY distance ASC LIMIT 10",
-            (hash, category.value, hash_type.value),
-        )
-
-        results = []
-        for label, distance in cursor.fetchall():
-            results.append(
-                ImageHashResult(
-                    hash_type=hash_type,
-                    category=category,
-                    label=label,
-                    confidence=(self.hash_length - distance) / self.hash_length,
-                )
-            )
-
-        return results
-
-    @staticmethod
-    def hash_mat_to_bytes(hash: Mat) -> bytes:
-        return bytes([255 if b else 0 for b in hash.flatten()])
-
-    def identify_image(self, category: ImageHashCategory, img) -> List[ImageHashResult]:
-        results = []
-
-        ahash = hashers.average(img, self.hash_size)
-        dhash = hashers.difference(img, self.hash_size)
-        phash = hashers.dct(img, self.hash_size, self.high_freq_factor)
-
-        results.extend(
-            self.lookup_hash(
-                category, ImageHashHashType.AVERAGE, self.hash_mat_to_bytes(ahash)
-            )
-        )
-        results.extend(
-            self.lookup_hash(
-                category, ImageHashHashType.DIFFERENCE, self.hash_mat_to_bytes(dhash)
-            )
-        )
-        results.extend(
-            self.lookup_hash(
-                category, ImageHashHashType.DCT, self.hash_mat_to_bytes(phash)
-            )
-        )
-
-        return results

src/arcaea_offline_ocr/dependencies/ihdb/models.py

@@ -1,46 +0,0 @@
-import dataclasses
-from enum import IntEnum
-from typing import Callable
-
-import cv2
-
-from arcaea_offline_ocr.types import Mat
-
-
-class ImageHashHashType(IntEnum):
-    AVERAGE = 0
-    DIFFERENCE = 1
-    DCT = 2
-
-
-class ImageHashCategory(IntEnum):
-    JACKET = 0
-    PARTNER_ICON = 1
-
-
-@dataclasses.dataclass
-class ImageHash:
-    hash_type: ImageHashHashType
-    category: ImageHashCategory
-    label: str
-    hash: bytes
-
-
-@dataclasses.dataclass
-class ImageHashResult:
-    hash_type: ImageHashHashType
-    category: ImageHashCategory
-    label: str
-    confidence: float
-
-
-def _default_imread_gray(image_path: str):
-    return cv2.cvtColor(cv2.imread(image_path, cv2.IMREAD_COLOR), cv2.COLOR_BGR2GRAY)
-
-
-@dataclasses.dataclass
-class ImageHashBuildTask:
-    image_path: str
-    category: ImageHashCategory
-    label: str
-    imread_function: Callable[[str], Mat] = _default_imread_gray

src/arcaea_offline_ocr/device/common.py

@@ -1,8 +1,9 @@
-from dataclasses import dataclass
 from typing import Optional
 
+import attrs
 
-@dataclass
+
+@attrs.define
 class DeviceOcrResult:
     rating_class: int
     pure: int

src/arcaea_offline_ocr/device/ocr.py

@@ -110,7 +110,7 @@ class DeviceOcr:
     @staticmethod
     def preprocess_char_icon(img_gray: Mat):
         h, w = img_gray.shape[:2]
-        img = cv2.copyMakeBorder(img_gray, max(w - h, 0), 0, 0, 0, cv2.BORDER_REPLICATE)
+        img = cv2.copyMakeBorder(img_gray, w - h, 0, 0, 0, cv2.BORDER_REPLICATE)
         h, w = img.shape[:2]
         img = cv2.fillPoly(
             img,

src/arcaea_offline_ocr/types.py

@@ -1,36 +1,25 @@
-from math import floor
+from collections.abc import Iterable
-from typing import Callable, NamedTuple, Union
+from typing import NamedTuple, Tuple, Union
 
 import numpy as np
 
 Mat = np.ndarray
 
-_IntOrFloat = Union[int, float]
-
 
 class XYWHRect(NamedTuple):
-    x: _IntOrFloat
+    x: int
-    y: _IntOrFloat
+    y: int
-    w: _IntOrFloat
+    w: int
-    h: _IntOrFloat
+    h: int
 
-    def _to_int(self, func: Callable[[_IntOrFloat], int]):
+    def __add__(self, other: Union["XYWHRect", Tuple[int, int, int, int]]):
-        return (func(self.x), func(self.y), func(self.w), func(self.h))
+        if not isinstance(other, Iterable) or len(other) != 4:
-
+            raise ValueError()
-    def rounded(self):
-        return self._to_int(round)
-
-    def floored(self):
-        return self._to_int(floor)
-
-    def __add__(self, other):
-        if not isinstance(other, (list, tuple)) or len(other) != 4:
-            raise TypeError()
 
         return self.__class__(*[a + b for a, b in zip(self, other)])
 
-    def __sub__(self, other):
+    def __sub__(self, other: Union["XYWHRect", Tuple[int, int, int, int]]):
-        if not isinstance(other, (list, tuple)) or len(other) != 4:
+        if not isinstance(other, Iterable) or len(other) != 4:
-            raise TypeError()
+            raise ValueError()
 
         return self.__class__(*[a - b for a, b in zip(self, other)])

src/arcaea_offline_ocr/utils.py

@@ -1,5 +1,5 @@
 from collections.abc import Iterable
-from typing import TypeVar, overload
+from typing import Callable, TypeVar, Union, overload
 
 import cv2
 import numpy as np
@@ -15,25 +15,32 @@ def imread_unicode(filepath: str, flags: int = cv2.IMREAD_UNCHANGED):
     return cv2.imdecode(np.fromfile(filepath, dtype=np.uint8), flags)
 
 
-@overload
+def construct_int_xywh_rect(
-def apply_factor(item: int, factor: float) -> float: ...
+    rect: XYWHRect, func: Callable[[Union[int, float]], int] = round
+):
+    return XYWHRect(*[func(num) for num in rect])
 
 
 @overload
-def apply_factor(item: float, factor: float) -> float: ...
+def apply_factor(item: int, factor: float) -> float:
+    ...
+
+
+@overload
+def apply_factor(item: float, factor: float) -> float:
+    ...
 
 
 T = TypeVar("T", bound=Iterable)
 
 
 @overload
-def apply_factor(item: T, factor: float) -> T: ...
+def apply_factor(item: T, factor: float) -> T:
+    ...
 
 
 def apply_factor(item, factor: float):
     if isinstance(item, (int, float)):
         return item * factor
-    if isinstance(item, XYWHRect):
-        return item.__class__(*[i * factor for i in item])
     if isinstance(item, Iterable):
         return item.__class__([i * factor for i in item])